Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 127.0.0.1 instead of localhost #54

Merged
merged 2 commits into from
Nov 24, 2022
Merged

use 127.0.0.1 instead of localhost #54

merged 2 commits into from
Nov 24, 2022

Conversation

bollwyvl
Copy link
Contributor

Hi, thanks for ypy-websocket.

When testing downstream (e.g in conda-forge/ypy-websocket-feedstock#21), docker containers can get confused with the localhost string (perhaps some IPv6 thing?). 127.0.0.1 seems to be more reliable.

davidbrochart
davidbrochart approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bollwyvl.

@davidbrochart davidbrochart merged commit 11cc7a3 into y-crdt:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bollwyvl @davidbrochart